Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip to future rounds when justified by an incoming message #241

Closed
Tracked by #246
anorth opened this issue May 16, 2024 · 0 comments · Fixed by #276
Closed
Tracked by #246

Skip to future rounds when justified by an incoming message #241

anorth opened this issue May 16, 2024 · 0 comments · Fixed by #276
Assignees
@masih
Labels
gossipbft Relates to core GossipPBFT protocol
Milestone
Milestone 0: F3 A...

Comments

@anorth
Copy link
Member

anorth commented May 16, 2024

Implement skipping ahead to a future round in the current instance when in receipt of a message for a subsequent round, and:

  • at least one CONVERGE for the higher round
  • a weak quorum of PREPARE messages for the higher round

See filecoin-project/FIPs#998
@anorth anorth added the gossipbft Relates to core GossipPBFT protocol label May 16, 2024
This was referenced May 17, 2024
Closed
Open
masih added a commit that referenced this issue May 23, 2024
@masih
Skip ahead to future rounds when justified
b242e35 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

Fixes #241
@masih masih mentioned this issue May 23, 2024
Merged
masih added a commit that referenced this issue May 24, 2024
@masih
Skip ahead to future rounds when justified
97990fc 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

Fixes #241
masih added a commit that referenced this issue May 24, 2024
@masih
Skip ahead to future rounds when justified
ea461a2 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

Fixes #241
masih added a commit that referenced this issue May 24, 2024
@masih
Skip ahead to future rounds when justified
c6edf7b 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

Fixes #241
masih added a commit that referenced this issue May 27, 2024
@masih
Skip ahead to future rounds when justified
8ef2182 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

Fixes #241
masih added a commit that referenced this issue May 27, 2024
@masih
Skip ahead to future rounds when justified
11783ce 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

The changes here introduce a test that should trigger skipping to future
rounds once reboradcast is implemented. The test uses a `Deny` adversary
where all messages to and from a set of targets are dropped until GST
has elapsed. For now, however, the test is skipped.

Fixes #241
masih added a commit that referenced this issue May 28, 2024
@masih
Skip ahead to future rounds when justified
b3e0ab0 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

The changes here introduce a test that should trigger skipping to future
rounds once reboradcast is implemented. The test uses a `Deny` adversary
where all messages to and from a set of targets are dropped until GST
has elapsed. For now, however, the test is skipped.

Fixes #241
@masih masih mentioned this issue May 28, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@masih
Skip ahead to future rounds when justified (#276)
f7a099e 
Implement a rebroadcast protocol improvement where upon receiving
sufficient justification a participant jumps ahead to future rounds.
Justification from a future rounds is considered sufficient when the
participant receives:
 * at least one `CONVERGE` message, and
 * a weak quorum of `PREPARE` messages

for that round.

The changes here introduce a test that should trigger skipping to future
rounds once reboradcast is implemented. The test uses a `Deny` adversary
where all messages to and from a set of targets are dropped until GST
has elapsed. For now, however, the test is skipped.

Fixes #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
gossipbft Relates to core GossipPBFT protocol
Projects
F3
Status: Done
Milestone
Milestone 0: F3 Alpha Code Freeze
Development

Successfully merging a pull request may close this issue.

Skip ahead to future rounds when justified filecoin-project/go-f3
2 participants
@masih @anorth