Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short-cut timeout in PREAPRE, COMMIT when justified by received messages #242

Open
Tracked by #246
anorth opened this issue May 16, 2024 · 0 comments · May be fixed by #289
Open
Tracked by #246

Short-cut timeout in PREAPRE, COMMIT when justified by received messages #242

anorth opened this issue May 16, 2024 · 0 comments · May be fixed by #289
Assignees
@masih
Labels
gossipbft Relates to core GossipPBFT protocol
Milestone
Milestone 0: F3 A...

Comments

@anorth
Copy link
Member

anorth commented May 16, 2024

  • Skip the timeout in PREPARE after it's impossible to reach a strong quorum in agreement with the local proposal.=
  • Skip the timeout in COMMIT after receiving a strong quorum of anything, including bottom.

See filecoin-project/FIPs#998
@anorth anorth added the gossipbft Relates to core GossipPBFT protocol label May 16, 2024
This was referenced May 17, 2024
Closed
Open
masih added a commit that referenced this issue May 29, 2024
@masih
Shortcut timeouts in PREPARE and COMMIT when justified
35117e2 
When sufficient justification is received do not wait for timeouts to
expire in PREPARE and COMMIT phase.

Fixes #242
@masih masih linked a pull request May 29, 2024 that will close this issue
Open
masih added a commit that referenced this issue Jun 4, 2024
@masih
Shortcut timeouts in PREPARE and COMMIT when justified
3a9c291 
When sufficient justification is received do not wait for timeouts to
expire in PREPARE and COMMIT phase.

Fixes #242
masih added a commit that referenced this issue Jun 4, 2024
@masih
Shortcut timeouts in PREPARE and COMMIT when justified
704ff8c 
When sufficient justification is received do not wait for timeouts to
expire in PREPARE and COMMIT phase.

Fixes #242
masih added a commit that referenced this issue Jun 5, 2024
@masih
Shortcut timeouts in PREPARE and COMMIT when justified
09c51f0 
When sufficient justification is received do not wait for timeouts to
expire in PREPARE and COMMIT phase.

Fixes #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
gossipbft Relates to core GossipPBFT protocol
Projects
F3
Status: In review
Milestone
Milestone 0: F3 Alpha Code Freeze
Development

Successfully merging a pull request may close this issue.

Shortcut timeouts in PREPARE and COMMIT when justified filecoin-project/go-f3
2 participants
@masih @anorth