Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to carry non-utf8 market labels over API boundaries #179

Open
ribasushi opened this issue Mar 24, 2023 · 2 comments
Open

Impossible to carry non-utf8 market labels over API boundaries #179

ribasushi opened this issue Mar 24, 2023 · 2 comments

Comments

@ribasushi
Copy link
Contributor

Because the JSON marshaller ignores the Bytes datamodel type, whenever one uses a non-utf8 ([]byte) label it is stripped off during RPC (JSON) transport

https://github.com/filecoin-project/go-state-types/blob/v0.10.0/builtin/v10/market/deal.go#L166-L168
+
https://github.com/filecoin-project/go-state-types/blob/v0.10.0/builtin/v10/market/deal.go#L184-L187

@arajasek @magik6k Is this intentional? If not any objections I fix it?
@arajasek
Copy link
Collaborator

@ribasushi Definitely not intentional, please fix.

@ribasushi
Copy link
Contributor Author

@arajasek actually seems intentional... can you double-confirm? #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ribasushi @arajasek