Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove methods from RegisteredXxxProof types #18

Open
anorth opened this issue Oct 24, 2020 · 2 comments
Open

Remove methods from RegisteredXxxProof types #18

anorth opened this issue Oct 24, 2020 · 2 comments

Comments

@anorth
Copy link
Member

anorth commented Oct 24, 2020

Methods on these integers are handy, but they complicate making any structural changes without integrating those changes into every actors release branch. E.g. we will probably want to remove RegisteredSealProof.RegisteredWindowPoStProof() because there's no necessary bijection there, but all call sites in all actors release branches need to handle that.

If such methods were free functions, we'd have more flexibility to change without forcing lots of work or a major version upgrade of this repo.

@jennijuju
Copy link
Member

is this still needed?

@anorth
Copy link
Member Author

anorth commented Aug 28, 2022

We still should do it IMO, but its importance depends on the versioning strategy for this repo. I'll defer to whoever has the vision for that @arajasek ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants