New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarshalCBOR should fail with a signature >=SignatureMaxLength, which will fail to decode #21

Open

wadealexc opened this issue Jan 15, 2021 · 0 comments

Labels

bug

Milestone

wadealexc commented Jan 15, 2021

UnmarshalCBOR limits payload to 200 bytes (SigType plus Data), but MarshalCBOR will serialize a signature that would fail to decode for this reason.

go-state-types/crypto/signature.go

Lines 76 to 78 in 7cab7f0

    
           if l > SignatureMaxLength { 
        
           	return fmt.Errorf("string too long") 
        
           }

anorth added the bug label

anorth added this to the 🧡 v3 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment