Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type of SectorAllocationClaim in Verifiedregistry #241

Closed
Terryhung opened this issue Jan 31, 2024 · 3 comments · Fixed by #262
Closed

Wrong type of SectorAllocationClaim in Verifiedregistry #241

Terryhung opened this issue Jan 31, 2024 · 3 comments · Fixed by #262
Labels
help wanted Extra attention is needed

Comments

@Terryhung
Copy link

There is a discrepancy between the schema SectorAllocationClaim in builtin-actors v12 and the schema SectorAllocationClaim in go-state-types v12.

Therefore, there is a mismatch between the SectorAllocationClaim in go-state-types v12 and the actual data.

The new schema should be this:

pub struct SectorAllocationClaims {
    pub sector: SectorNumber,
    pub expiry: ChainEpoch,
    pub claims: Vec<AllocationClaim>,
}

Then I found it did not be fixed in v13, is there any plan for fix it?

Thanks!

@Stebalien
Copy link
Member

If you make a PR, I'll review it.

@LuisCherry
Copy link

Excuse me, may I ask when this issue can be fixed

@rvagg
Copy link
Member

rvagg commented May 7, 2024

to be fair to OP, changing these while making cbor-gen happy in the interim isn't exactly easy, here's a fix: #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
5 participants