Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13 migration: market: Consider checking deal expiration epoch for the cached migration #251

Open
arajasek opened this issue Feb 28, 2024 · 0 comments

Comments

@arajasek
Copy link
Collaborator

We're currently relying on the fact of the protocol to avoid looking up deal proposals for the cached migration. Specifically, we assume that no deals could have been added between the pre-migration and migration that have already expired.

While this is true given how Lotus intends to use this migration, and given the protocol parameters for minimum deal duration today, it would be nice to avoid doing this by just looking up the proposal for any new deals. This isn't very fast, but there will likely be only a small number of such deals (about 10 hours worth), so we might as well do it for correctness.

Resolves this TODO:

// TODO: We should technically only set this if the deal hasn't expired,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant