Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace for_each_mut (internal iteration) with iter_mut (external iteration) in the AMT #1996

Open
Stebalien opened this issue Feb 20, 2024 · 2 comments
Open

Replace for_each_mut (internal iteration) with iter_mut (external iteration) in the AMT #1996

Stebalien opened this issue Feb 20, 2024 · 2 comments
Assignees
@PhantomOz
Labels
Hint: Good first issue Good for newcomers Kind: Improvement An improvement of something that exists.

Comments

@Stebalien
Copy link
Member

The iterator will have to yield a smart pointer that:

  1. Can be dereferenced immutably with no affect.
  2. Can be dereferenced mutably, marking the value as changed.
  3. Can be deleted (e.g., by calling some form of ptr.delete() method). This method should consume the smart pointer (possibly returning the inner value).

This will get rid of the last "internal" iteration feature.
@Stebalien Stebalien added Kind: Improvement An improvement of something that exists. Hint: Good first issue Good for newcomers labels Feb 20, 2024
@Stebalien Stebalien mentioned this issue Feb 20, 2024
Closed
@PhantomOz
Copy link

can i work on this?

@Stebalien
Copy link
Member Author

Absolutely! Take a look at how we currently use it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhantomOz PhantomOz

Labels
Hint: Good first issue Good for newcomers Kind: Improvement An improvement of something that exists.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @PhantomOz