Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add sector ID to logs #1319

Open
karalabe opened this issue Oct 18, 2020 · 1 comment
Open

Feature request: Add sector ID to logs #1319

karalabe opened this issue Oct 18, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@karalabe
Copy link

Currently all the sealing logs are context-less. If I'm running 7-10 different sectors concurrently on the same machine, it's impossible to see which log belongs to which sector. When something fails, it's almost impossible to gather back the trace. It's also super hard to see which sector is at what progress. E.g.

/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:363","msg":"  generated layer 8 store with id layer-8"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:368","msg":"  setting exp parents"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:320","msg":"generating layer: 9"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:363","msg":"  generated layer 8 store with id layer-8"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:368","msg":"  setting exp parents"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:320","msg":"generating layer: 9"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:363","msg":"  generated layer 4 store with id layer-4"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:368","msg":"  setting exp parents"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:320","msg":"generating layer: 5"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:363","msg":"  generated layer 4 store with id layer-4"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:368","msg":"  setting exp parents"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:320","msg":"generating layer: 5"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:354","msg":"  storing labels on disk"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:363","msg":"  generated layer 8 store with id layer-8"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:368","msg":"  setting exp parents"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:320","msg":"generating layer: 9"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:354","msg":"  storing labels on disk"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:354","msg":"  storing labels on disk"}
/src/github.com-1ecc6299db9ec823/storage-proofs-porep-5.1.4/src/stacked/vanilla/proof.rs:363","msg":"  generated layer 8 store with id layer-8"}

Would be nice to pass the sector ID through to the logger so each log could be tagged with the sector it belongs to.

@dignifiedquire
Copy link
Contributor

@vmx wanna take a look at adding some context to our logs?

@dignifiedquire dignifiedquire added the enhancement New feature or request label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants