Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha2raw fails to build in Windows on an ARM device #1718

Open
jdjaustin opened this issue Sep 19, 2023 · 3 comments
Open

sha2raw fails to build in Windows on an ARM device #1718

jdjaustin opened this issue Sep 19, 2023 · 3 comments

Comments

@jdjaustin
Copy link

jdjaustin commented Sep 19, 2023

Description

sha2raw fails to build in Windows on an ARM device. Removing the default asm feature from sha2raw/Cargo.toml allows the crate to build.

Acceptance criteria

sha2raw builds without error in Windows on an ARM device.

Risks + pitfalls

Where to begin

@vmx
Copy link
Contributor

vmx commented Sep 19, 2023

It's cool to hear that sha1raw it can be built under Windows on ARM without any further changes. Is anything missing then or can this issue be closed?

@jdjaustin
Copy link
Author

It's cool to hear that sha1raw it can be built under Windows on ARM without any further changes. Is anything missing then or can this issue be closed?

I'm not sure I understand. In Windows on ARM, sha2raw currently fails to build without manually disabling the default asm feature. The crate would need to check the architecture and disable asm under Windows on ARM to build without manual changes.

@vmx
Copy link
Contributor

vmx commented Sep 19, 2023

Thanks for the clarification, so you try to build rust-fil-proofs as a whole under Windows on ARM?

Currently Windows is not supported and we have no intention to do. Though if PRs are provided that make it easier to build on unsupported platforms like Windows, without causing issues for the currently supported platforms, we are happy to review and merge those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants