Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Separation of components and containers #5

Open
ghost opened this issue Dec 23, 2015 · 1 comment
Open

Clear Separation of components and containers #5

ghost opened this issue Dec 23, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented Dec 23, 2015

Hey there,

Was looking at the code and I personally would prefer to put up any dispatch outside of the components.
Example here id rather have this as a props passed by the parent container.

The idea is to have UI drawing in components and anything else abstracted into its parent container.

  • Store Actions are in containers
  • Views are in components

So in your structure, if u want to change actions, u will be updating the component not the container.. which is counter intuitive.
Besides, it looks like ur container is only a wrapper for redux and then dumps it into the component. Not that useful IMHO :)

What do u think @fraserxu ? :)

@fraserxu
Copy link
Owner

Hi @Turg0n Thanks for the heads up!

Sorry I'm just switching to a new job and don't have enough time for this project. It would be great if you could create a pull request to show your idea and I'm happy to discuss your idea there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant