Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] add benchmark action to comment on each PR #514

Open
ftonato opened this issue Jun 8, 2021 · 1 comment
Open

[Suggestion] add benchmark action to comment on each PR #514

ftonato opened this issue Jun 8, 2021 · 1 comment

Comments

@ftonato
Copy link
Owner

ftonato commented Jun 8, 2021

Question

I was wondering if it makes sense to add an action to run the benchmark for each pull-request, so we can identify if we want or not to merge the change (if it doesn't turn the solution into something so bad, what do you think?

Idea:

  • We run the action to test if everthing still working
  • We run the benchmark/index.ts file and grab all info and send as a comment on the PR, then we can easly understand if make sense or not to merge
@bvego
Copy link
Collaborator

bvego commented Jun 8, 2021

I think that's a great idea!

Benchmarks do need a little touchup. Some time should be taken to get the output more reliably and probably add other validation lib test suites to see how we compare to them

Thanks for the suggestion! Makes perfect sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants