-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puppeteer issue with Apple Silicon chips #6885
Comments
My temporary solution:
OR TLDR: add these to
|
@gaecoli From memory, you use macOS yeah? If that's the case, then this ^^^ sounds like it'll be useful and we could add it to the package.json. 😄 |
@square-li Thanks heaps, that does sound useful. 😁 |
From what I understand, that package is used for frontend automated test. If anyone who just wants to test and run the app, they shouldn't be blocked on this. |
The same result. |
@justinclift This seems to be a problem and we should look at how to fix it. 😄 |
I have found some solutions, but it's best to allow users to install dependencies directly through yarn without doing any extra work. |
No worries. It sounds like we should create an extra page on the wiki for people using macOS, so we can give people the macOS specific steps. If there's not much difference to the main "Local dev setup" page then we don't have to include the whole thing, we can just tell people what differences to install first or something. What do you reckon? 😄 |
That kind of sounds like "people who just want to use the app rather than develop it". If that's what you're meaning (?), then for that situation we should probably extend the official setup.sh repository scripting to support macOS. That might not be too hard. Not really sure yet though as I've not tried it. 😄 |
Yeah, I think we're in agreement here. If we can update things to automatically work for people so they don't need to follow extra instructions, that would be best. If "automatic" doesn't work though, then at least having extra instructions for macOS users is probably the right approach. |
Ok |
Sorry I was missing to mention you would need to install chromium for arm as well. "brew install chromium" then modify the package.json solves my issue. |
@square-li Any interest in creating a new page on the wiki with instructions for macOS users trying to get a dev environment set up? 😄 |
For sure. I would love to. |
Awesome, please do. You should already have the right permissions for making changes on the wiki, and if you hit issues or have questions then please ask here or anywhere else suitable. 😄 If Discord is your kind of thing, then we have a chat server for developers to discuss stuff. You're welcome to join it: |
On Node >=18:
Based on this: puppeteer/puppeteer#6622 (comment) I was also able to change |
Cool, that looks potentially useful too. Thanks @wtfiwtz. 😄 |
Cool! This good to me. |
added PR #6912, which upgrades percy and cypress, which fixes this issue. please test it if it works for you |
Issue Summary
With Apple Silicon chips (ARM), execute
yarn
to install dependencies will fail likeSteps to Reproduce
yarn
on MacBook with Apple SiliconAny other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?
Technical details:
The text was updated successfully, but these errors were encountered: