-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interactionsSampleRate removed in v8 #12006
Comments
Hey, thanks for raising this. |
Hi @mfb apologies for the apologies, I have to reopen this issues. We have serious concerns about the For the moment, I'd recommend to remove the Sorry for the back and forth! |
Yes, I'm not sure it was necessary (although it allowed me to do weird things, like set interactionsSampleRate higher than 1 so that I could increase the rate above tracesSampleRate for purposes of quickly seeing what it looked like in the Sentry UI :) I just wanted to mention so it could be documented |
Good point about raising the sample rate :) To be fair, I think that's also a valid use case, depending on what you want to achieve 😅 (and as long as the value stays below 1.0 fwiw). Anyway, I opened #12064 to update the migration guide as we decided internally that we'll keep the option removed in v8. Concrete reasons:
To migrate off, you probably can just remove the option for the reasons outlined above, or use // v7
Sentry.init({
integrations: [new BrowserTracing({ interactionsSampleRate: 0.1 })],
}); // v8 - please read the text above, you most likely don't need this :)
Sentry.init({
tracesSampler: (ctx) => {
if (ctx.attributes?['sentry.op']?.startsWith('ui.interaction')) {
return 0.1;
}
return 0.5;
}
}) If interaction/INP spans become more powerful in the future, we might revisit this decision. |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/browser
SDK Version
8.0.0
Framework Version
No response
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce
On v7 I was able to configure an interactionsSampleRate; on v8 I didn't see evidence of this being applied, nor is present in the codebase, so I believe it was removed?
Expected Result
If interactionsSampleRate was removed, should be documented in the changelog/migration guide.
Actual Result
No documentation about the option being removed.
The text was updated successfully, but these errors were encountered: