Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Quart Tests #3044

Open
szokeasaurusrex opened this issue May 3, 2024 · 0 comments
Open

Improve Quart Tests #3044

szokeasaurusrex opened this issue May 3, 2024 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented May 3, 2024

Our quart tests failed to detect that the Quart integration was completely broken. We should improve them so that they would have detected the failures in the below situation:

It is very surprising that our test suite did not detect that this integration was completely broken. Perhaps, this is a limitation of the Quart test_client we use in testing. We should certainly add tests to make sure we do not break in this way again, but that can likely be done later, most important is to quickly fix the broken integration ASAP

Originally posted by @szokeasaurusrex in #3043 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant