Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for add_note() / __notes__ #3050

Open
arjenzorgdoc opened this issue May 7, 2024 · 1 comment
Open

Add support for add_note() / __notes__ #3050

arjenzorgdoc opened this issue May 7, 2024 · 1 comment
Labels
Enhancement New feature or request Good first issue Good for newcomers

Comments

@arjenzorgdoc
Copy link

Problem Statement

Python 3.11 added support for notes:

async def f4():
    try:
        await f3()
    except TypeError as e:
        e.add_note('this failed while trying to blah')
        raise

(Source: https://blog.sentry.io/python-3-11-release-top-5-things-to-know/#adding-notes-to-exceptions)

I don't see them in sentry.

Solution Brainstorm

Check if an exception has a __notes__ property and add them to the "message" field.

@arjenzorgdoc arjenzorgdoc added the Enhancement New feature or request label May 7, 2024
@szokeasaurusrex
Copy link
Member

Good idea! Seems like something we should look into supporting. We would also be happy to accept PRs for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants