Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic sampling context might be missing from Celery Beat transactions #3068

Closed
szokeasaurusrex opened this issue May 13, 2024 · 0 comments · Fixed by #3070
Closed

Dynamic sampling context might be missing from Celery Beat transactions #3068

szokeasaurusrex opened this issue May 13, 2024 · 0 comments · Fixed by #3070
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented May 13, 2024 •
edited

How do you use Sentry?

Sentry Saas (sentry.io)

Version

Latest 2.x

Steps to Reproduce

Update: See here for a simple demonstration of the broken behavior.

Under investigation – if the dynamic sampling context is missing from transactions started in Celery Beat, this would explain strange behavior we observe in Sentry where the parent (Celery Beat) transaction is missing while the child transactions are all present

Expected Result

Celery Beat transactions contain a dynamic sampling context

Actual Result

In some cases, the dynamic sampling context might be missing
@szokeasaurusrex szokeasaurusrex self-assigned this May 13, 2024
szokeasaurusrex added a commit to szokeasaurusrex/issue-reproductions that referenced this issue May 13, 2024
@szokeasaurusrex
Add getsentry/sentry-python#3068 reproduction
63c8276
szokeasaurusrex added a commit that referenced this issue May 14, 2024
@szokeasaurusrex
feat(tracing): Only propagate headers from spans within transactions
e42bac5 
This change ensures that we only propagate trace headers from spans that are within a transaction. This fixes a bug where any child transactions of a span created outside a transaction are missing a dynamic sampling context and are part of a trace missing a root transaction (because the root is the span).

Fixes #3068
@szokeasaurusrex szokeasaurusrex mentioned this issue May 14, 2024
Merged
szokeasaurusrex added a commit that referenced this issue May 15, 2024
@szokeasaurusrex
fix(tracing): Only propagate headers from spans within transactions
a1d0c76 
This change ensures that we only propagate trace headers from spans that are within a transaction. This fixes a bug where any child transactions of a span created outside a transaction are missing a dynamic sampling context and are part of a trace missing a root transaction (because the root is the span).

Also, remove/modify tests that were asserting the old behavior.

Fixes #3068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tracing): Only propagate headers from spans within transactions getsentry/sentry-python
1 participant
@szokeasaurusrex