Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent decimal evaluation #102

Open
kaidesu opened this issue Jan 29, 2022 · 2 comments
Open

Inconsistent decimal evaluation #102

kaidesu opened this issue Jan 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@kaidesu
Copy link
Member

kaidesu commented Jan 29, 2022

When evaluating 0.4 the evaluation is correct. When evaluating 0 . 4 it seems that the evaluator is treating this as a property and panics:

Ghost (1.0-beta.1)
Press Ctrl + C to exit

>> 0.4
0.4
>> 0 . 4
panic: interface conversion: ast.ExpressionNode is *ast.Number, not *ast.Identifier

goroutine 1 [running]:
ghostlang.org/x/ghost/evaluator.evaluateProperty(0xc0000dc120, 0xa)
	/Users/kai/Code/Ghost/ghost/src/evaluator/property.go:44 +0x54e
ghostlang.org/x/ghost/evaluator.Evaluate({0x430d160, 0xc0000dc120}, 0x414d297)
	/Users/kai/Code/Ghost/ghost/src/evaluator/evaluator.go:68 +0x127
ghostlang.org/x/ghost/evaluator.Evaluate({0x430cce0, 0xc0000c6660}, 0xc0000cc190)
	/Users/kai/Code/Ghost/ghost/src/evaluator/evaluator.go:36 +0x4c9
ghostlang.org/x/ghost/evaluator.evaluateProgram(0x3, 0x0)
	/Users/kai/Code/Ghost/ghost/src/evaluator/program.go:12 +0x77
ghostlang.org/x/ghost/evaluator.Evaluate({0x430d120, 0xc0000a65e8}, 0x40cfa25)
	/Users/kai/Code/Ghost/ghost/src/evaluator/evaluator.go:18 +0xc8
ghostlang.org/x/ghost/ghost.(*Ghost).Execute(0xc0000c3d90)
	/Users/kai/Code/Ghost/ghost/src/ghost/ghost.go:76 +0x18a
ghostlang.org/x/ghost/repl.evaluate(0xc0000c3d90, {0xc0000b23c0, 0x5})
	/Users/kai/Code/Ghost/ghost/src/repl/repl.go:59 +0xb9
ghostlang.org/x/ghost/repl.Start({0x43ebc20, 0xc0000ae008}, {0x437e89d, 0x18})
	/Users/kai/Code/Ghost/ghost/src/repl/repl.go:45 +0x2e6
main.main()
	/Users/kai/Code/Ghost/ghost/src/cmd/ghost.go:64 +0x677
exit status 2
make: *** [run] Error 1
@kaidesu kaidesu added the bug Something isn't working label Jan 29, 2022
@kaidesu kaidesu added this to the v1.0 Beta 2 milestone Jan 29, 2022
@kaidesu kaidesu self-assigned this Jan 29, 2022
@kaidesu
Copy link
Member Author

kaidesu commented Jan 29, 2022

Interestingly enough, the same thing is a syntax error in python 3:

>>> 0.4
0.4
>>> 0 . 4
  File "<stdin>", line 1
    0 . 4
        ^
SyntaxError: invalid syntax

@pleaseful
Copy link
Contributor

It's fixed already, you can close this now.

@kaidesu kaidesu removed their assignment Oct 27, 2023
@kaidesu kaidesu removed this from the v1.0 Beta 2 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants