Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A8-5-2: Create query to cover auto case #463

Open
lcartey opened this issue Nov 30, 2023 · 0 comments
Open

A8-5-2: Create query to cover auto case #463

lcartey opened this issue Nov 30, 2023 · 0 comments
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Low user-report Issue reported by an end user of CodeQL Coding Standards

Comments

@lcartey
Copy link
Collaborator

lcartey commented Nov 30, 2023

Affected rules

  • A8-5-2

Description

The rule A8-5-2 (use braced initialization) conflicts with rule A8-5-3 (A variable of type auto shall not be initialized using {} or ={} braced-initialization). This is because C++14 will deduce auto x2{10}; as std::initializer_list, which is usually not what the developer intended. This behaviour is changed in C++17, and in practice many compilers also address it in C++14 mode.

In order to use auto in a codebase and remain compliant to AUTOSAR a deviation is required either on A8-5-3, to allow braced initialization for auto variables where the compiler supports this, or for A8-5-2, to permit the use of = initialization with auto.

In the latter case we want to be able to deviate only on those cases which are declared as auto. To facilitate that we will split the rule between the auto and not auto. Currently, our query only supports the "non-auto" case.

Example

auto v = init();
@lcartey lcartey added Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-High user-report Issue reported by an end user of CodeQL Coding Standards labels Nov 30, 2023
@lcartey lcartey self-assigned this Nov 30, 2023
@lcartey lcartey changed the title A8-5-2: Split rule on auto/non-auto` A8-5-2: Split rule on auto/non-auto Dec 1, 2023
@lcartey lcartey changed the title A8-5-2: Split rule on auto/non-auto A8-5-2: Create query to cover auto case Dec 1, 2023
@lcartey lcartey removed their assignment Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Low user-report Issue reported by an end user of CodeQL Coding Standards
Projects
Development

No branches or pull requests

1 participant