Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container action does not get inputs that have hyphen in the name #32671

Open
1 task done
ijpatricio opened this issue Apr 25, 2024 · 4 comments
Open
1 task done
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@ijpatricio
Copy link

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action

What part(s) of the article would you like to see updated?

So I followed the instructions on the page, and used an input like so:

        with:
          who-to-greet: Arnold

it turns out, after long trial and error, that hypen makes it not available on the Docker container.

I would suggest to make that a warning callout, and use underscores in the example.

I'm ready to make that PR if you agree with this, just let me know.

Additional information

Below, you'll find what I tired, and marked them as working or not!

You can also see the action repo, so just reach out if any questions! https://github.com/unitedbycode/alfredo

image

@ijpatricio ijpatricio added the content This issue or pull request belongs to the Docs Content team label Apr 25, 2024
Copy link

welcome bot commented Apr 25, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 25, 2024
@Mpl198

This comment was marked as spam.

@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 25, 2024
@nguyenalex836
Copy link
Contributor

@ijpatricio Thank you for opening this issue! I'll get this triaged for review ✨

@ijpatricio
Copy link
Author

@nguyenalex836 glad I can help!! Let me know if should I do that PR to docs, thank you for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

4 participants
@ijpatricio @nguyenalex836 @Mpl198 and others