Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grc-qt Saving file blanks the file name in the file name tab #7297

Closed
chrisjohgorman opened this issue May 1, 2024 · 1 comment · Fixed by #7381
Closed

grc-qt Saving file blanks the file name in the file name tab #7297

chrisjohgorman opened this issue May 1, 2024 · 1 comment · Fixed by #7381
Labels

Comments

@chrisjohgorman
Copy link

What happened?

When saving a file the file name in the tab gets blanked. I've attached a screenshot of before file save and after. I expected the filename to stay in the tab.

qt_file_name_tab_0
qt_file_name_tab_1

System Information

OS: Arch Linux
GR Installation Method: Source

GNU Radio Version

3.10 (maint-3.10)

Specific Version

3.10.10.0

Steps to Reproduce the Problem

  1. open a grc file in the qt gnuradio-companion
  2. make a small adjustment to a block.
  3. save the file.

The filename is now blank.

Relevant log output

No response

@haakov
Copy link
Contributor

haakov commented May 5, 2024

Thank you for these bug reports!

If someone tries to fix this bug before I do:
This bug occurs only with the light theme. The filename isn't blank, it is just white, which happens to be almost the same color as the tab background. These are the two lines that set the tab text to white:

self.tabWidget.tabBar().setTabTextColor(self.tabWidget.currentIndex(), Qt.white) # TODO: Not quite the right hue

self.tabWidget.tabBar().setTabTextColor(self.tabWidget.currentIndex(), Qt.white) # TODO: Not quite the right hue

The text shouldn't be white, it should be self.app().getCurrentStyleSheet().getStandardTextColor() (or something like that :)

dl1ksv added a commit to dl1ksv/gnuradio that referenced this issue Jun 1, 2024
At the moment the text color in some widgets is hardcoded to white.
This makes the text invisible in the light mode.

Variable names and values in the variable editor sometimes are hard to read.
So now use the palette settings to get the correct colors.

Fixes gnuradio#7297

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
willcode pushed a commit that referenced this issue Jun 3, 2024
At the moment the text color in some widgets is hardcoded to white.
This makes the text invisible in the light mode.

Variable names and values in the variable editor sometimes are hard to read.
So now use the palette settings to get the correct colors.

Fixes #7297

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants