Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grc-qt Variable Editor window does not reinitialize when a new flowgraph is slected #7305

Closed
chrisjohgorman opened this issue May 3, 2024 · 2 comments · Fixed by #7357
Closed
Labels
GRC-Qt maint-3.10 Applies to maint-3.10 branch

Comments

@chrisjohgorman
Copy link

chrisjohgorman commented May 3, 2024

What happened?

A new flowgraph fails to refresh the variable editor window and populate the window with the variables from the new flowgraph.

System Information

OS: Arch Linux
GR Installation Method: Source

GNU Radio Version

3.10 (maint-3.10)

Specific Version

3.10.10.0

Steps to Reproduce the Problem

  1. Open a flowgraph
  2. Select the new button
  3. The new flowgraph is displayed, but in the Variable Editor window the variables are from the old flowgraph.

Relevant log output

No response

@chrisjohgorman

This comment was marked as outdated.

@marcusmueller marcusmueller added maint-3.10 Applies to maint-3.10 branch GRC-Qt labels May 4, 2024
@haakov
Copy link
Contributor

haakov commented May 19, 2024

Looks like this has been fixed with #7287

dl1ksv added a commit to dl1ksv/gnuradio that referenced this issue May 20, 2024
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: gnuradio#7305
Fixes: gnuradio#7306
Fixes: gnuradio#7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
dl1ksv added a commit to dl1ksv/gnuradio that referenced this issue May 20, 2024
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: gnuradio#7305
Fixes: gnuradio#7306
Fixes: gnuradio#7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
willcode pushed a commit that referenced this issue May 21, 2024
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: #7305
Fixes: #7306
Fixes: #7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
willcode pushed a commit to willcode/gnuradio that referenced this issue May 27, 2024
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: gnuradio#7305
Fixes: gnuradio#7306
Fixes: gnuradio#7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
(cherry picked from commit f360dce)
Signed-off-by: Jeff Long <willcode4@gmail.com>
willcode pushed a commit that referenced this issue May 27, 2024
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: #7305
Fixes: #7306
Fixes: #7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
(cherry picked from commit f360dce)
Signed-off-by: Jeff Long <willcode4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GRC-Qt maint-3.10 Applies to maint-3.10 branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants