Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grc-qt Variable Editor variable_editor_add_import and variable_editor_add_varible don't work #7307

Closed
chrisjohgorman opened this issue May 3, 2024 · 0 comments · Fixed by #7357
Closed

grc-qt Variable Editor variable_editor_add_import and variable_editor_add_varible don't work #7307

chrisjohgorman opened this issue May 3, 2024 · 0 comments · Fixed by #7357
Labels
GRC-Qt

Comments

@chrisjohgorman
Copy link

What happened?

When I attempt to add a variable or import via the Variable Editor, the menu options do not work at the moment. In the gtk interface these two buttons add either a variable or an import to the canvas.

System Information

OS: Arch Linux
GR Installation Method: Source

GNU Radio Version

3.10 (maint-3.10)

Specific Version

3.10.10.0

Steps to Reproduce the Problem

  1. run gnuradio-companion --qt
  2. In the Variable Editor window right click.
  3. Select either variable_editor_add_import or variable_editor_add_variable
  4. Neither work at the moment, the most done is to add to the console output. (See Relevant log output)

Relevant log output

[I] <<< Welcome to GNU Radio Companion 3.10.10.0 >>>

PyQt 5.15.10
GUI preferences file: /home/chris/.gnuradio/grc_qt.conf
Block paths:
	/home/chris/.grc_gnuradio
	/usr/share/gnuradio/grc/blocks
	/usr/local/share/gnuradio/grc/blocks
[D] devicePixelRatio 1.0
[D] VariableEditorAction.ADD_IMPORT triggered!
[D] VariableEditorAction.ADD_VARIABLE triggered!
dl1ksv added a commit to dl1ksv/gnuradio that referenced this issue May 20, 2024
@dl1ksv
grc-qt: Variable editor: fix several bugs
0118d50 
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: gnuradio#7305
Fixes: gnuradio#7306
Fixes: gnuradio#7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
@dl1ksv dl1ksv mentioned this issue May 20, 2024
Merged
6 tasks
dl1ksv added a commit to dl1ksv/gnuradio that referenced this issue May 20, 2024
@dl1ksv
grc-qt: Variable editor: fix several bugs
e92bc68 
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: gnuradio#7305
Fixes: gnuradio#7306
Fixes: gnuradio#7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
willcode pushed a commit to willcode/gnuradio that referenced this issue May 27, 2024
@dl1ksv @willcode
grc-qt: Variable editor: fix several bugs
a554651 
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: gnuradio#7305
Fixes: gnuradio#7306
Fixes: gnuradio#7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
(cherry picked from commit f360dce)
Signed-off-by: Jeff Long <willcode4@gmail.com>
willcode pushed a commit that referenced this issue May 27, 2024
@dl1ksv @willcode
grc-qt: Variable editor: fix several bugs
05055ac 
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk

But as all the functionsof the editor like  add/delete/enable/disable block are
already coded int the Mainwindow it's sufficient to map this functions from the editor
by signal and slot mechanism to the correspondend functions in the Mainwindow.

Fixes: #7305
Fixes: #7306
Fixes: #7307

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
(cherry picked from commit f360dce)
Signed-off-by: Jeff Long <willcode4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GRC-Qt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

grc-qt: Variable editor: fix several bugs dl1ksv/gnuradio
2 participants
@marcusmueller @chrisjohgorman