Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CMake requirement to 3.22 on main #7323

Open
marcusmueller opened this issue May 7, 2024 · 2 comments
Open

Bump CMake requirement to 3.22 on main #7323

marcusmueller opened this issue May 7, 2024 · 2 comments
Assignees
Labels
CMake dependencies pending maintainer/architect decision Things that need an authorative decision to move on

Comments

@marcusmueller
Copy link
Member

marcusmueller commented May 7, 2024

Feature Description

As seen in #7322, we tend to use cmake features not present in the fairly ancient minimum CMake version we demand (3.8); in that case, we'd need at least 3.20.

Considering cmake versions:

distro release cmake ver
debian oldstable (bullseye) 3.18
debian stable (bookworm) 3.25
Ubuntu 22.04 3.22
Ubuntu 23.10 3.27
Ubuntu 24.04 3.28
Ubuntu 24.10 3.27
Fedora 39 3.27
Fedora 40 3.28

I'd say that even for maint-3.10, cmake 3.18 would be safe (and I think even without #7294 we do use 3.16-ish features, anyway) . For main, we should go to at least 3.22 (if we decide that we want to target Ubuntu 22.04 with maint-3.10), or staright for 3.25.

So, this boils down to deciding:

  • maint-3.10: Update at all? Updated to 3.18 or 3.22?
  • main: Update to 3.22 or 3.25?

Feature Urgency

medium (would be nice to have in the near future)

More Information

No response

@dkozel
Copy link
Contributor

dkozel commented May 8, 2024

@johnwparent and @mwoehlke-kitware Tagging you both as an FYI of the discussion and to ask for input on what features you're hoping or expecting to use in the installer work.

Thanks!

@willcode
Copy link
Member

@marcusmueller Ubuntu 20.04 has 3.16 and has EOL in 2025, so we'd have to drop support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake dependencies pending maintainer/architect decision Things that need an authorative decision to move on
Projects
None yet
Development

No branches or pull requests

4 participants