Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC APIs #182

Open
phated opened this issue Mar 23, 2023 · 2 comments
Open

Add GC APIs #182

phated opened this issue Mar 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@phated
Copy link
Member

phated commented Mar 23, 2023

Binaryen 111 added C APIs for most GC-related functions, such as:
WebAssembly/binaryen@version_110...version_111#diff-5d2db7a99567fbac5e617fd39709fbdca0a2d22b92a97d5c3515caf7dba9f78bR1035-R1154 and WebAssembly/binaryen@version_110...version_111#diff-5d2db7a99567fbac5e617fd39709fbdca0a2d22b92a97d5c3515caf7dba9f78bR2335-R2706

However, they left them all as TODO in the JS code (see WebAssembly/binaryen@version_110...version_111#diff-9f4ceff4b9bcc272e133f83651e487c15f772e6115c88023c2435cc5226d8b68R2438-R2448)

We generally don't want to bind to things that can't be bound in JS, so we should check to see if these APIs were added in v112 and implement them when available.

It also seems like we need to implement an API for the "type builder" API in binaryen.

@spotandjake
Copy link
Member

The gc-related instructions are still marked as todo in version_112 from what I can tell https://github.com/WebAssembly/binaryen/blob/728b37cbe95ca8ea8cfba9ebc70e3fcb14db273a/src/js/binaryen.js-post.js#L2430-L2440

@spotandjake spotandjake added the enhancement New feature or request label Mar 23, 2023
@peblair
Copy link
Member

peblair commented Oct 15, 2023

Tracker issue for adding bindings to Binaryen.js: WebAssembly/binaryen#5921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants