Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting Juce Assertion when using tabs in JuceGUI.h #891

Open
jdsierral opened this issue May 2, 2023 · 5 comments
Open

Hitting Juce Assertion when using tabs in JuceGUI.h #891

jdsierral opened this issue May 2, 2023 · 5 comments

Comments

@jdsierral
Copy link
Contributor

Hello, I'm using JuceGUI.h outside of faust2juce to auto generate some quick GUIs in Juce and I'm hitting an assertion in the file

juce_TabbedButtonBar.cpp in line 248 from the JUCE Repo. This seems to be the case whenever I use a tgroup in Faust

Obviously this is at Juce's Repo, but from what I understand this comes from

the openTabBox in JuceGUI.h (Line 1943), where a label is passed but the tab creation of the tab box doesn't use the label.

To solve this I modified the constructor of uiTabBox in line 1595 to receive the label and called its own setName in the body of the constructor. Not sure if this is the best way to solve it but thought it would be better to share just in case ;)

Best

JuanS

@sletz
Copy link
Member

sletz commented May 2, 2023

Can you prepare a PR ?

@jdsierral
Copy link
Contributor Author

ok :) will do

@sletz
Copy link
Member

sletz commented May 12, 2023

Anything ?

@jdsierral
Copy link
Contributor Author

Sorry for the super late reply just had time to come back to this. Just did it

@sletz
Copy link
Member

sletz commented Jul 26, 2023

Done in 250157a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants