Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] General issues #14

Open
NickColley opened this issue Mar 11, 2016 · 3 comments
Open

[a11y] General issues #14

NickColley opened this issue Mar 11, 2016 · 3 comments

Comments

@NickColley
Copy link

You can see the actual padding and I've drawn a box for an example of how big the padding could be (you could use psuedo elements to increase the touch area here)
(Related http://www.lukew.com/ff/entry.asp?1085)

  • Animating the navigation means it's unusable for a few seconds on load, would recommend only animating the hero or setting a flag to say 'seen animation' and don't show it again to the user.

Extension for Chrome Dev tools to catch some of these automatically:

@varjmes
Copy link
Contributor

varjmes commented Mar 11, 2016

The light blue links are also badly contrasted.

@espy
Copy link
Collaborator

espy commented Mar 24, 2017

I never got a round to thank you for this issue, you two! So thanks a lot! 😻 I feel a bit bad I didn’t get around to this previously, but I’ve done some updates to the site, and I’ve improved:

  • hitbox sizes for links
  • line height in paragraphs
  • faster menu animations
  • font sizes

I’m still not quite sure how to improve the contrast without throwing all of the colours overboard, but I’m on that :)

@NickColley
Copy link
Author

NickColley commented Mar 27, 2017

@espy yeah unfortunately green is very hard to contrast with white, for what it's worth it'll work on a dark background but imagine you were trying to get away from the hacker vibes ;)

Thanks for following this up 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants