Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue where setting the "namespace" to FALSE breaks the build #57

Closed
wants to merge 5 commits into from

Conversation

SimonChong
Copy link

This fixes #56

Also added a feature that enables adding of an optional banner and / or footer

@sindresorhus
Copy link
Member

Also added a feature that enables adding of an optional banner and / or footer

That should have been a separate pull request. But we don't want this anyways as you should rather use a separate grunt task for this, like grunt-header.

Happy to receive a PR with just the fix though.

@SimonChong
Copy link
Author

Your response is disappointing because grunt-contrib-cssmin (which you also maintain has this functionality). Not to mention grunt-contrib-uglify , grunt-contrib-less , grunt-contrib-concat , and others.

I actually used the code from the other repos mentioned (which is probably code you wrote or already reviewed).

If I should use grunt-header wouldn't it be logical for you to strip this functionality out of the other grunt-contrib plugins I mentioned?

@moraleslevi
Copy link

According the the documentation this should work, but does not. Not sure why this PR was closed. Is this actively maintained anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namespace set to false results in: Warning: Cannot read property 'namespace'
5 participants