Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support for new API_GATEWAY default_size_inspection_limit in aws_wafv2_web_acl #37512

Closed
0x4456 opened this issue May 14, 2024 · 3 comments · Fixed by #37588
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@0x4456
Copy link

0x4456 commented May 14, 2024

Description

https://docs.aws.amazon.com/waf/latest/APIReference/API_AssociationConfig.html now supports CLOUDFRONT | API_GATEWAY | COGNITO_USER_POOL | APP_RUNNER_SERVICE | VERIFIED_ACCESS_INSTANCE but the aws_wafv2_web_acl resource only has configuration options for cloudwatch.

Affected Resource(s) and/or Data Source(s)

aws_wafv2_web_acl

Potential Terraform Configuration

association_config {
    request_body {
      api_gateway {
        default_size_inspection_limit = "KB_64"
      }
    }
  }

References

https://docs.aws.amazon.com/waf/latest/APIReference/API_AssociationConfig.html

https://aws.amazon.com/about-aws/whats-new/2024/03/aws-waf-larger-body-inspections-regional-resources/

Would you like to implement a fix?

No

@0x4456 0x4456 added the enhancement Requests to existing resources that expand the functionality or scope. label May 14, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 14, 2024
@0x4456 0x4456 changed the title [Enhancement]: Support for new API_GATEWAY default_size_inspection_limit in aws_wafv2_web_acl [Enhancement]: Support for new API_GATEWAY default_size_inspection_limit in aws_wafv2_web_acl May 14, 2024
@ewbankkit ewbankkit added service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 20, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.51.0 milestone May 20, 2024
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
2 participants