[Bug]: aws_cloudtrail always shows changes due to switching insight_type values

[snarky]

Terraform Core Version

1.8.3

AWS Provider Version

5.49.0

Affected Resource(s)

• aws_cloudtrail

Expected Behavior

Terraform should recognize that there are no actual changes in the insight_selector blocks and should not show any updates in the execution plan.

Actual Behavior

Terraform shows an in-place update with the insight_type values switching:

Relevant Error/Panic Output Snippet

~ insight_selector {
    ~ insight_type = "ApiErrorRateInsight" -> "ApiCallRateInsight"
}
~ insight_selector {
    ~ insight_type = "ApiCallRateInsight" -> "ApiErrorRateInsight"
}

Terraform Configuration Files

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudtrail

Steps to Reproduce

Define an aws_cloudtrail resource with insight_selector blocks:

resource "aws_cloudtrail" "cloudtrail" {
  name = "XXX"

  insight_selector {
    insight_type = "ApiErrorRateInsight"
  }

  insight_selector {
    insight_type = "ApiCallRateInsight"
  }
}

Run terraform apply twice.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[acwwat]

Looks like the order in the AWS API response is not deterministic - sometimes the order is OK, sometimes it's not. In any case, it makes sense to make the argument unordered using a Set as a catch-all.