New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ESLint or use TypeScript-ESLint #172

Open

azu opened this issue Nov 29, 2020 · 0 comments

Labels

Type: Maintenance Type: TypeScript

Member

azu commented Nov 29, 2020

The current ESLint config is for JavaScript.

honkit/package.json

Line 23 in e22d856

"lint": "eslint .",

But, we already migrate the codebase to TypeScript in #24 #169
So, the current ESLint does not work.

We have two options:

Remove ESLint
Migrate to use TypeScript ESLint

I think that we improve typing in TypeScript at first.
The Lint phase is next to typing.
So, We can just remove ESLint temporarily.

If we need to get ESLint, we add it again in the future.

azu added Type: Maintenance Type: TypeScript labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment