Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub and Bluefire Reader (iOS / iPadOS) dark mode #275

Open
pronoiac opened this issue Jun 27, 2022 · 2 comments
Open

epub and Bluefire Reader (iOS / iPadOS) dark mode #275

pronoiac opened this issue Jun 27, 2022 · 2 comments
Labels
help wanted Extra attention is needed Type: Feature New Feature

Comments

@pronoiac
Copy link

Summary

I made an epub, and the text doesn't change from black when in dark mode in Bluefire Reader on my iPad.

  • HonKit version: 3.7.1
  • Calibre / ebook-convert version: 5.40.0

Step to reproduce

  1. Generate an epub.
  2. Open it in Bluefire Reader.
  3. Switch from light theme to dark theme, while watching some text.
  • Link to code example: My book.json code is basic, with only root, title, and author. While I haven't committed it yet, as this is exploratory, let me know if it would be useful.

Expected results

In dark mode / dark theme, the text is lighter.
These are the results whether generated with pandoc, or viewed in Apple Books.

Actual results

In dark mode / dark theme, the text is black.
I verified it wasn't just my setup by looking at the most recent Byte of Python epub, which was a top result to googling "honkit epub", and confirming the issue is there.

@azu azu added Type: Feature New Feature help wanted Extra attention is needed labels Jun 27, 2022
@azu
Copy link
Member

azu commented Jun 27, 2022

@pronoiac
Copy link
Author

pronoiac commented Jul 6, 2022

Note, I've been in touch with Bluefire support, including sending a link to this issue.

For quicker iterating:

  • I can reproduce the issue in calibre's ebook-viewer.
  • A quick and dirty way to repack a folder into an epub: zip -rX ../alpha-testing.epub mimetype META-INF/ OEBPS/ *

Theory:
The ebook's font color settings override the app's.
(In comparison, I looked at a pandoc epub; its stylesheet1.css was empty.)

Workaround:
Commenting out lines with colors in stylesheet.css - color or background and #[0-9a-f]+ - seems to fix the issue.
Hitting .section did the most, fixing the main text, but I kept hitting more cases, so I ended up commenting them all out.
(This didn't include border, yet, though maybe it should.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Type: Feature New Feature
Projects
None yet
Development

No branches or pull requests

2 participants