Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse parent body's scroll overflow instead of making body-inner memorize scroll position #310

Open
vintprox opened this issue Nov 2, 2022 · 0 comments
Open

Reuse parent body's scroll overflow instead of making body-inner memorize scroll position #310

vintprox opened this issue Nov 2, 2022 · 0 comments
Labels
help wanted Extra attention is needed Type: Theme Theme related

Comments

@vintprox
Copy link

vintprox commented Nov 2, 2022

It's usually a good practice to use <body> or <html>'s scroll behavior, because browsers implement a reproducible scroll position. Problem with current approach that was inherited from GitBook is one having CSS rule .body-inner { overflow-y: auto } and unnecessarily leaving memorization to JavaScript, which produces white flash on page reload.

Parent body must take the height of main content that currently resides in div.body-inner. I think it won't take much layout reworking: just make .book-summary sticky and remove scroll overflow from inner body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Type: Theme Theme related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azu @vintprox