Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not jump between footnote reference and definition in some cases #313

Open
lindeer opened this issue Nov 7, 2022 · 2 comments
Open
Labels

Comments

@lindeer
Copy link

lindeer commented Nov 7, 2022

Summary

If footnote label contains '.', jumping between reference and definition would failed. I think this issue was caused by our gitbook.js or theme.js, 'cause when I removed them, jumping is OK.

markdown-it's label rendering is different with other markdown library, but that is ok, Also an old bug since gitbook, hope it could be fixed.

  • HonKit version: 4.0.4

Step to reproduce

  1. in one page file, insert a footnote reference whose label contains '.'
  2. after rendering, click footnote reference
  • Link to code example:
some text[^130.1].

<large amount of content, so that page could be 'scrollable'>

[^130.1]: some footnote definition.

Expected results

jump to footnote definition.

Actual results

nothing happened.

@azu azu added Type: Bug Bug or Bug fixes Type: Markdown labels Nov 7, 2022
@azu
Copy link
Member

azu commented Nov 7, 2022

Maybe #286 is similar issue.

Fundamentally, I feel that replacing the Markdown parser is a good idea. #96

@lindeer
Copy link
Author

lindeer commented Nov 7, 2022

I think this case may not caused by Markdown parser, when I removed gitbook.js and theme.js, jumping is fine. sorry for no more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants