Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issues #137

Open
finnp opened this issue Apr 9, 2015 · 9 comments
Open

Accessibility Issues #137

finnp opened this issue Apr 9, 2015 · 9 comments
Assignees

Comments

@finnp
Copy link
Member

finnp commented Apr 9, 2015

Hey :),

there are a few things that could be improved about the a11y of your website. Have a look at this audit here: http://wave.webaim.org/report#/http%3A%2F%2Fhood.ie . Especially the default contrast of your top nav bar slightly fails AA, so you might want to make that font bigger or darken the orange a bit.

I would love to PR some changes, but your repo is like 140 Mb big and needs forever for me to clone. Maybe there are some binary files you can remove from the repo history?

Best,
Finn

@verpixelt
Copy link
Member

Hey @finnp thanks for you offer <3. I'll look into the issue with the repository file size. It's the blog media, of two years, which bloats everything up.

@verpixelt verpixelt self-assigned this Apr 9, 2015
@janl
Copy link
Member

janl commented Apr 9, 2015

The file size is due to media on the blog, sorry. We should sign up for this: https://github.com/blog/1986-announcing-git-large-file-storage-lfs

@janl
Copy link
Member

janl commented Apr 9, 2015

I signed us up, let’s see what happens :)

@verpixelt
Copy link
Member

That's a good idea but we should clean up this folders anyway. There are 4 versions of every image created by Wordpress, which we used before.

I will have a look into it sometime this week.

@gr2m gr2m changed the title Accessibiity Issues Accessibility Issues May 24, 2015
@varjmes
Copy link
Contributor

varjmes commented Jul 2, 2015

Hey @finnp, thank you so much for bringing this to our attention.
I'm sorry that we haven't responded in a while but please know we are thinking about this. I recently became an official contributor to Hood.ie and my almost-complete focus is making hood.ie accessible. Tackling the main website is certainly at the top of my list and I will be using this PR and my own auditing to put together a list of things that must be improved to create an awesomely accessible experience :)

@finnp
Copy link
Member Author

finnp commented Jul 2, 2015

@Charlotteis That sounds really great! Glad to see someone take care of this.

@varjmes
Copy link
Contributor

varjmes commented Jul 2, 2015

@janl @verpixelt We now have git-lfs enabled on this repository, as Jan tells me. Here is how to use it: https://github.com/github/git-lfs#getting-started. I am trying to do it myself, but am having some installation problems, so if someone else could also take a look: that'd be great.

@varjmes
Copy link
Contributor

varjmes commented Jul 2, 2015

I got it working. However, it seems that git-lfs will not work retrospectively. That is, when we start tracking the files we want, it will only turn them into pointers when we add new ones. So, we need to find a solution to de-bigify (a very technical word) our repository as it currently is. I believe @janl has some thoughts.

My question is, what file extensions would we like to track for git-lfs?

@varjmes
Copy link
Contributor

varjmes commented Jul 2, 2015

I've started to talk about large file storage over here: #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants