Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edit button #230

Open
gr2m opened this issue Feb 23, 2016 · 6 comments
Open

Add Edit button #230

gr2m opened this issue Feb 23, 2016 · 6 comments
Labels

Comments

@gr2m
Copy link
Member

gr2m commented Feb 23, 2016

As we use jekyll for http://hood.ie/, all pages can be directly edited on GitHub. For example, the content of http://hood.ie/community/ can be edited here: https://github.com/hoodiehq/hood.ie/edit/gh-pages/community/index.html (You need to be signed in)

To make it simpler for visitors to fix a typo and help with improving our site in general, we would like to add an edit button to every page, like on http://nobackend.org/ (bottom right of page)

Here is how the code looks like for the edit button:
https://github.com/noBackend/nobackend.org/blob/gh-pages/_layouts/page.html#L57

We would love something similar on http://hood.ie/ :)

@gr2m gr2m added the starter label Feb 23, 2016
@espy
Copy link
Member

espy commented Feb 23, 2016

That's totally on my list since I saw that Ember does it too (pencil icon on the right):

bildschirmfoto 2016-02-23 um 09 53 24

Good idea!

@NickColley
Copy link
Contributor

We do something similar for PouchDB:

http://pouchdb.com/guides/

https://github.com/pouchdb/pouchdb/blob/master/docs/_layouts/default.html#L74

https://github.com/pouchdb/pouchdb/blob/master/docs/_includes/edit_button.html

This way you can turn it on and off depending on the page using frontmatter.

@bartw
Copy link

bartw commented Mar 12, 2016

I'd like to try to implement this.

But I'm having troubles getting the site working on my machine.
The scss files won't compile and it seems that head.html contains a link to the css on hoodiehq instead of something variable.

Anybody got some pointers?

@gr2m
Copy link
Member Author

gr2m commented Mar 12, 2016

@bartw thanks Bart!

what ruby version do you have installed (ruby -v)? You might need to update to the latest. Then you need to install jekyll and 2 plugins

gem install jekyll jekyll-redirect-from jekyll-paginate

and then, in theory, you should be able to do jekyll serve --watch. If you get any errors, can you post them here?

@dristibutola
Copy link

Hi !! I would like to work on this issue.Secondly for edit button do , i need to create it for just the main page hoodie.ie or for its other dependent pages as well.
Thanks

@gr2m
Copy link
Member Author

gr2m commented Feb 24, 2017

I think you could add the edit button to the header*.html files here: https://github.com/hoodiehq/hood.ie/tree/gh-pages/_includes

Note that the setup is currently quite complicated with CSS being served from another place. We hope to clean this all up soon via #312. But feel free to give it a try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants