Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin.accounts.find/update/remove(object) #96

Open
courajs opened this issue May 28, 2016 · 5 comments
Open

admin.accounts.find/update/remove(object) #96

courajs opened this issue May 28, 2016 · 5 comments

Comments

@courajs
Copy link

courajs commented May 28, 2016

Find, update, and remove are documented as accepting an object with an id, username, or token property, but currently only work when passed a string id.
When passed an object they mistakenly try to GET http://localhost:4200/hoodie/account/api/accounts/[object%20Object]

@gr2m
Copy link
Member

gr2m commented May 29, 2016

Great catch! That would make a great starter issue for https://github.com/hoodiehq/camp/issues :) Anyone feel free to go ahead and create one, otherwise I’ll get back to it as soon as I can

@courajs
Copy link
Author

courajs commented May 29, 2016

I'd enjoy creating my first starter issue 😀

How do we find a user by username? I couldn't figure it out from an (admittedly quick) look at hoodie-account-server.

Same for token. What are the tokens, and where do they come from?

We could also keep it super short and only add the .id option in the starter issue. Or do just id and username if the token is more complicated or not supported yet

@gr2m
Copy link
Member

gr2m commented May 30, 2016

Tokens are currently out of scope. They can later be used for one-time logins, e.g. for password resets.

This one is actually tricky, I get back to it as soon as I can :) If you like we can also work on it together

@courajs
Copy link
Author

courajs commented May 31, 2016

We could in the meantime add {id: ...} support, and throw NotImplementedError or similar for username/token. Do you think that kind of thing is worth it in general? To match documentation?

@gr2m
Copy link
Member

gr2m commented May 31, 2016

yeah, we did that in the past. NotImplementedError is great, and then ideally add URL to an open issue to fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants