Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If /hoodie/client.js cannot be loaded or JS is disabled, show helpful message #22

Open
gr2m opened this issue Mar 1, 2016 · 3 comments

Comments

@gr2m
Copy link
Member

gr2m commented Mar 1, 2016

right now we have this

screen shot 2016-02-29 at 7 41 08 pm

@jsimplicio
Copy link
Collaborator

Cool, how about we have a message for users with JS turned off? I don't know how to do this in code so I need help. Same thing for client.js failing to load. Which we fixed with npm install and restarting the server

@gr2m
Copy link
Member Author

gr2m commented Mar 1, 2016

Same thing for client.js failing to load. Which we fixed with npm install

That won’t happen anymore, it was do due to hoodiehq/discussion#89

The reason why screen is blank is because we hide everything until we set the data-account-state property: https://github.com/hoodiehq/hoodie-app-tracker/blob/master/www/assets/app.css#L81

This was to avoid flicker, because if user is signed in, then the app was shown for a short time as signed out, until hoodie does its thing.

I don’t know what the simplest solution is here :) Maybe it’s out of scope for us right now. I’d say let’s leave the issue open and see if it remains an issue or not?

@jsimplicio
Copy link
Collaborator

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants