Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get /hoodie/client.js fails with npm2 #758

Open
gr2m opened this issue Jun 3, 2017 · 0 comments
Open

Get /hoodie/client.js fails with npm2 #758

gr2m opened this issue Jun 3, 2017 · 0 comments

Comments

@gr2m
Copy link
Member

gr2m commented Jun 3, 2017

We bundle the hoodie client.js dynamically on first request to GET /hoodie/client.js, see

hoodieBundleSource += ' PouchDB: require("pouchdb-browser")\n'

The require('pouchdb-browser') fails in npm2 because it’s a sub dependency and does not exist in node_modules/pouchdb-browser but node_modules/hoodie/node_modules/pouchdb-browser instead

I’m not sure if there is a clever way to work around that, so that we remain compatible with npm2, or if we give up on it. The work around is to install pouchdb-browser and @hoodie/client as dependencies of the app itself:

npm install --save pouchdb-browser @hoodie/client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant