Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm deprecation warnings #774

Open
mk-pmb opened this issue Jun 9, 2017 · 8 comments
Open

npm deprecation warnings #774

mk-pmb opened this issue Jun 9, 2017 · 8 comments

Comments

@mk-pmb
Copy link

mk-pmb commented Jun 9, 2017

You might want to upgrade these deps:

npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated nodemailer@2.7.2: All versions below 4.0.1 of Nodemailer are deprecated. See https://nodemailer.com/status/

There may be more but I got bored watching the install so maybe I'll update the post once install finished.

@gr2m
Copy link
Member

gr2m commented Jun 10, 2017

Thanks @mk-pmb!

It’s not as straight forward to update them. Some context

the minimatch seems to come from @hoodie/admin which we is a bit stale in its development, it’s also a sub sub sub sub sub dependency so I’m not sure how easy it will be to update for us

├─┬ @hoodie/admin@1.3.1
│ └─┬ ember-truth-helpers@1.3.0
│   └─┬ ember-cli-babel@5.2.4
│     ├─┬ broccoli-babel-transpiler@5.6.2
│     │ └─┬ babel-core@5.8.38
│     │   └── minimatch@2.0.10 

we want to remove the nodemailer dependency altogether from @hoodie/account-server and have people implement things like email reset password flows themselves via plugins

└─┬ @hoodie/server@23.0.0
  └─┬ @hoodie/account-server@6.1.0
    └── nodemailer@2.7.2

we could probably update nodemailer to v4 in @hoodie/acount-server though as its a direct dependency

@digitalhemanth
Copy link

npm install -g nodemailer

    // use this command 

@mk-pmb
Copy link
Author

mk-pmb commented Feb 27, 2018

@digitalhemanth If installing a current version of the deprecated dependency globally turns off the deprecation warning on your node, I'd consider that a hint that your node might have problems with dependency resolution.

@dhuang612
Copy link
Contributor

Is this something I can work on?

@gr2m
Copy link
Member

gr2m commented Nov 2, 2019

Sure, feel free to :)

@dhuang612
Copy link
Contributor

created the following PR
#891

@dhuang612
Copy link
Contributor

I can start on the devDependencies next

@dhuang612
Copy link
Contributor

created PR #892
for deprecation warnings under dev dependencies!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@gr2m @mk-pmb @digitalhemanth @dhuang612 and others