Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvm uses wrong import path for archiver/extractor and no longer compiles from source #193

Open
Bo98 opened this issue Mar 26, 2020 · 1 comment
Labels

Comments

@Bo98
Copy link

Bo98 commented Mar 26, 2020

What didn't work?

Installing dvm from source no longer works.

$ brew install -s dvm

...

dvm-helper/internal/downloader/downloader.go:14:2: code in directory /private/tmp/dvm-20200322-44150-8mhegy/dvm-1.0.2/src/github.com/howtowhale/dvm/vendor/github.com/pivotal-golang/archiver/extractor expects import "code.cloudfoundry.org/archiver/extractor"

archiver/extractor should be vendored as code.cloudfoundry.org/archiver/extractor and imported as such instead of github.com/pivotal-golang/archiver/extractor. This is documented in their README.

What should it have done?

Successfully build from source.

Helpful Context

What version of dvm are you using? 1.0.2

What is your Operating System? macOS Mojave 10.14.6

What is your shell (bash/powershell/cmd/fish)? Bash

How did you install dvm (command-line,chocolatey,homebrew)? Homebrew

Do you like kittens? 😸

@carolynvs
Copy link
Collaborator

Thanks for the heads up!

@carolynvs carolynvs added the bug label Mar 26, 2020
iMichka added a commit to iMichka/homebrew-core that referenced this issue Feb 24, 2022
Fails to build with:
2022-02-23T07:54:29.0917180Z [34m==>[0m [1mmake VERSION=1.0.2 UPGRADE_DISABLED=true[0m
2022-02-23T07:54:29.0917590Z Last 150 lines from /Users/brew/actions-runner-x86_64/_work/homebrew-core/homebrew-core/bottles/logs/dvm/01.make:
2022-02-23T07:54:29.0917930Z 2022-02-23 07:54:23 +0000
2022-02-23T07:54:29.0918040Z
2022-02-23T07:54:29.0918100Z make
2022-02-23T07:54:29.0918270Z VERSION=1.0.2
2022-02-23T07:54:29.0918440Z UPGRADE_DISABLED=true
2022-02-23T07:54:29.0918550Z
2022-02-23T07:54:29.0918930Z objc[49605]: Class AMSupportURLConnectionDelegate is implemented in both /usr/lib/libamsupport.dylib (0x1fa9cb678) and /Library/Apple/System/Library/PrivateFrameworks/MobileDevice.framework/Versions/A/MobileDevice (0x1064982c8). One of the two will be used. Which one is undefined.
2022-02-23T07:54:29.0919680Z objc[49605]: Class AMSupportURLSession is implemented in both /usr/lib/libamsupport.dylib (0x1fa9cb6c8) and /Library/Apple/System/Library/PrivateFrameworks/MobileDevice.framework/Versions/A/MobileDevice (0x106498318). One of the two will be used. Which one is undefined.
2022-02-23T07:54:29.0920180Z fatal: not a git repository (or any of the parent directories): .git
2022-02-23T07:54:29.0920750Z CGO_ENABLED=0 go build -a -tags netgo -ldflags '-w -X main.dvmCommit= -X main.dvmVersion=1.0.2 -X main.upgradeDisabled=true' -o dvm-helper/dvm-helper github.com/howtowhale/dvm/dvm-helper
2022-02-23T07:54:29.0921220Z # github.com/howtowhale/dvm/dvm-helper/dockerversion
2022-02-23T07:54:29.0921570Z dvm-helper/dockerversion/dockerversion.go:75:33: undefined: dockerArch
2022-02-23T07:54:29.0921940Z dvm-helper/dockerversion/dockerversion.go:96:35: undefined: dockerArch
2022-02-23T07:54:29.0922280Z dvm-helper/dockerversion/query.go:34:102: undefined: dockerArch
2022-02-23T07:54:29.0922510Z make: *** [local] Error 2

Upstream looks somewhat inactive and we did not get a fix for our last request, see howtowhale/dvm#193

I almost wanted to deprecated dvm, but as the Intel build is still fine, I'm disabling it for ARM
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this issue Feb 25, 2022
Fails to build with:
2022-02-23T07:54:29.0917180Z [34m==>[0m [1mmake VERSION=1.0.2 UPGRADE_DISABLED=true[0m
2022-02-23T07:54:29.0917590Z Last 150 lines from /Users/brew/actions-runner-x86_64/_work/homebrew-core/homebrew-core/bottles/logs/dvm/01.make:
2022-02-23T07:54:29.0917930Z 2022-02-23 07:54:23 +0000
2022-02-23T07:54:29.0918040Z
2022-02-23T07:54:29.0918100Z make
2022-02-23T07:54:29.0918270Z VERSION=1.0.2
2022-02-23T07:54:29.0918440Z UPGRADE_DISABLED=true
2022-02-23T07:54:29.0918550Z
2022-02-23T07:54:29.0918930Z objc[49605]: Class AMSupportURLConnectionDelegate is implemented in both /usr/lib/libamsupport.dylib (0x1fa9cb678) and /Library/Apple/System/Library/PrivateFrameworks/MobileDevice.framework/Versions/A/MobileDevice (0x1064982c8). One of the two will be used. Which one is undefined.
2022-02-23T07:54:29.0919680Z objc[49605]: Class AMSupportURLSession is implemented in both /usr/lib/libamsupport.dylib (0x1fa9cb6c8) and /Library/Apple/System/Library/PrivateFrameworks/MobileDevice.framework/Versions/A/MobileDevice (0x106498318). One of the two will be used. Which one is undefined.
2022-02-23T07:54:29.0920180Z fatal: not a git repository (or any of the parent directories): .git
2022-02-23T07:54:29.0920750Z CGO_ENABLED=0 go build -a -tags netgo -ldflags '-w -X main.dvmCommit= -X main.dvmVersion=1.0.2 -X main.upgradeDisabled=true' -o dvm-helper/dvm-helper github.com/howtowhale/dvm/dvm-helper
2022-02-23T07:54:29.0921220Z # github.com/howtowhale/dvm/dvm-helper/dockerversion
2022-02-23T07:54:29.0921570Z dvm-helper/dockerversion/dockerversion.go:75:33: undefined: dockerArch
2022-02-23T07:54:29.0921940Z dvm-helper/dockerversion/dockerversion.go:96:35: undefined: dockerArch
2022-02-23T07:54:29.0922280Z dvm-helper/dockerversion/query.go:34:102: undefined: dockerArch
2022-02-23T07:54:29.0922510Z make: *** [local] Error 2

Upstream looks somewhat inactive and we did not get a fix for our last request, see howtowhale/dvm#193

I almost wanted to deprecated dvm, but as the Intel build is still fine, I'm disabling it for ARM

Closes #95803.

Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants