This doesn't compile. Can you make sure you run check and tests locally via:

cargo check --no-default-features --features=hyper_client

cargo test --no-default-features --features=hyper_client

Sorry, let me check later today

It seems the main branch doesn't compile on wasm either, due to error from getrandom.

@Fishrock123 it compiles on all targets. However, because the getrandom dependency was introduced in http-types, I'm not sure if it's good to add target check here

@sunng87 Could you add a separate feature flag for this? That we we can land it sooner.

@Fishrock123 I'm not quite sure if a feature flag could fix this. Could you please show me some detail about that?

I've just run into this via http-rs/surf#295, is there any action to follow this up?

this could work but needs to be under a versioned flag, e.g. hyper-014

@Fishrock123

Do you mean that you prefer a feature flag such as:

[features]
wasm_getrandom = ["getrandom/js"]
wasm_client = ["other features",  "wasm_getrandom"]

Instead of:

[target.'cfg(target_arch = "wasm32")'.dependencies.getrandom]
version = "0.2.2"
features = ["js"]

Otherwise, can you elaborate so we can get this merged soon? :)

Please review this PR, it would be great to be able to use surf with Tokio 1.0 :-)