Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futures are used to store the return values from RPC calls. #2

Open
hypercube-lab opened this issue Sep 8, 2021 · 3 comments
Open
Labels
0.1 good first issue Good for newcomers question Further information is requested
Milestone

Comments

@hypercube-lab
Copy link
Owner

The accountant stub routines are all contained inside a single block. That's OK for the time being, but we'll want to switch to all async calls as soon as possible. For now, wrapping each return value in a future and updating the callers (most of whom are in client-demo.rs) to utilize them is a good first step toward getting there.

See https://crates.io/crates/futures for further information.

It's worth noting that the tokio framework reexports the same future library, which means that if we utilize it as our async runtime, the move will be seamless.

@hypercube-lab hypercube-lab added this to the Testnet milestone Sep 8, 2021
@hypercube-lab hypercube-lab added good first issue Good for newcomers question Further information is requested labels Sep 9, 2021
@agnitazudkll
Copy link
Contributor

What version of futures were you considering?

@agnitazudkll
Copy link
Contributor

I saw it and it includes a ton of major breaking changes from 0.1.21, so I wanted to see what others thought.

@agnitazudkll
Copy link
Contributor

it's definitely an improvement but a little tricky since it's a whole new framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.1 good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants