-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL language causes clipped aspect ratio button #4913
Comments
low-batt
added a commit
that referenced
this issue
May 5, 2024
This commit will change the constraint on the CustomAspectRatio text field from "width == 60" to "width >= 30". This allows this field to be compressed allowing the segmented control to expand enough to avoid clipping the default button.
2 tasks
2 tasks
looks good |
To my understanding, this is not an RTL specific issue right? The PR looks good tho. |
uiryuu
pushed a commit
that referenced
this issue
May 24, 2024
This commit will change the constraint on the CustomAspectRatio text field from "width == 60" to "width >= 30". This allows this field to be compressed allowing the segmented control to expand enough to avoid clipping the default button.
Yes. This one has more to do with the length of the text. |
uiryuu
pushed a commit
that referenced
this issue
May 25, 2024
This commit will change the constraint on the CustomAspectRatio text field from "width == 60" to "width >= 30". This allows this field to be compressed allowing the segmented control to expand enough to avoid clipping the default button.
Should close as resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System and IINA version:
Expected behavior:
Names of buttons are normally not clipped.
Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language and open the quick setting panel the
Default
("ברירת מחדל") button underAspect ratio
is clipped:This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this particular problem.
Steps to reproduce:
Pull PR feat: enable hebrew locale #4864
Open the IINA project in Xcode
Under the
Product
menu open theScheme
menu and selectEdit Scheme…
Click on the
Options
tabScroll down to the
App Language
settingIn the pull down select
Hebrew
Start IINA running under Xcode
Start playing a video
Press ⇧⌘V to show the video panel
Notice the
Default
("ברירת מחדל") button is clippedMPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: