Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(servicemonitor): patch metrics labels to prefix with immich_ #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(servicemonitor): patch metrics labels to prefix with immich_ #89

wants to merge 1 commit into from

Conversation

hiteshnayak305
Copy link
Contributor

@hiteshnayak305 hiteshnayak305 commented Apr 14, 2024 •
edited

Description of the change

Add immich_ prefix to metrics labels as per discussion immich-app/immich#8191 (comment)

Should be reverted when pragmaticivan/nestjs-otel#265 is fixed

Applicable issues

@hiteshnayak305
fix(servicemonitor): patch metrics labels to prefix with immich_
ff9426f 
Signed-off-by: Hitesh Nayak <hiteshnayak305@gmail.com>
bo0tzz
bo0tzz requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

As noted in the linked discussion, it seems like immich-server metrics already come prefixed with immich_. We can either not relabel those, or perhaps use a regex like proposed there?

@hiteshnayak305
Copy link
Contributor Author

do we have list of metrices, i tried in my local k8s cluster. will look into once it again.

@hiteshnayak305
Copy link
Contributor Author

hiteshnayak305 commented Apr 15, 2024 •
edited

I am unable to see any metrics mentioned in that discussion. Not sure if something missing in my configuration ?
immich_server_container

immich_server_8081_metrics.txt

@bo0tzz
Copy link
Member

bo0tzz commented Apr 15, 2024

It seems they only exist for jobs. Maybe if you haven't run any jobs since starting the pod, it doesn't export those metrics?
image

@hiteshnayak305
Copy link
Contributor Author

as per this comment immich-app/immich#8191 (reply in thread) suggested regex is not compiling in prometheus. not sure how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo0tzz bo0tzz bo0tzz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metricsRelabelings to servicemonitors
2 participants
@hiteshnayak305 @bo0tzz