Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve "Make it a bit less ugly" of FileService::getCombinedIdentifier() #531

Open
julianhofmann opened this issue Nov 29, 2023 · 0 comments

Comments

@julianhofmann
Copy link

There's a "@todo" in FileService::getCombinedIdentifier() for making it less ugly.

The method is only used once: in FileService::indexFile() for getting the sys_file's uid.
Replacing the use of getFileObjectFromCombinedIdentifier() by retrieveFileOrFolderObject() would make FileService::getCombinedIdentifier() (and FileService::substituteFileadminFromPathAndName) unnecessary.

Pitfall: retrieveFileOrFolderObject() could theoretically return a Folder-object. By checking the fille extension before, this edge case should already avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant