You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a "@todo" in FileService::getCombinedIdentifier() for making it less ugly.
The method is only used once: in FileService::indexFile() for getting the sys_file's uid.
Replacing the use of getFileObjectFromCombinedIdentifier() by retrieveFileOrFolderObject() would make FileService::getCombinedIdentifier() (and FileService::substituteFileadminFromPathAndName) unnecessary.
Pitfall: retrieveFileOrFolderObject() could theoretically return a Folder-object. By checking the fille extension before, this edge case should already avoided.
The text was updated successfully, but these errors were encountered:
There's a "@todo" in
FileService::getCombinedIdentifier()
for making it less ugly.The method is only used once: in FileService::indexFile() for getting the sys_file's uid.
Replacing the use of
getFileObjectFromCombinedIdentifier()
byretrieveFileOrFolderObject()
would makeFileService::getCombinedIdentifier()
(andFileService::substituteFileadminFromPathAndName
) unnecessary.Pitfall:
retrieveFileOrFolderObject()
could theoretically return aFolder
-object. By checking the fille extension before, this edge case should already avoided.The text was updated successfully, but these errors were encountered: