Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation link can be clicked multiple times #559

Open
mhuber84 opened this issue Apr 8, 2024 · 2 comments
Open

Confirmation link can be clicked multiple times #559

mhuber84 opened this issue Apr 8, 2024 · 2 comments

Comments

@mhuber84
Copy link
Contributor

mhuber84 commented Apr 8, 2024

If the user clicks the link in the confirmation email multiple times, the finishers get executed every time. But they should get executed only once.

A return true; in the if ($user->getTxFemanagerConfirmedbyuser()) in NewController::statusUserConfirmation() helps. Can someony confirm this?

Edit: Removed "but then the userConfirmationRedirect is not executed anymore"

@epxfrho
Copy link

epxfrho commented Apr 10, 2024

I can confirm that issue and the return true; workaround. Similar problem in if ($user->getTxFemanagerConfirmedbyadmin()) in NewController::statusAdminConfirmation().

However, I do not find it necessary to redirect to the newAction at this point. The user clicks on the confirmation link several times, so he/she has an account, why show the form?

@akiessling
Copy link

Can confirm the issue, return true; works. The redirect should be dropped, i don't see the usecase for that either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants