Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global config.linkVars settings are interfering with ajax requests #24

Open
guelzow opened this issue Dec 21, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@guelzow
Copy link

guelzow commented Dec 21, 2021

Hi everyone.

The page TypeNum is added globally to all linkVars here:
https://github.com/in2code-de/lux/blob/develop/Configuration/TypoScript/Lux/20_Configuration.typoscript#L2

When an other TypeNum is used (for example) an ajax search then it's TypeNum is added to every URL generated in the search.
That severely limits the usefulness of this search, because it always points back to the ajax search entrypoint.

Proposed solution:
Add the linkVars to their PageTypes locally, where they are used, and not globally where everybody else is using them.

Tobi

@einpraegsam
Copy link
Contributor

Thx for the valuable feedback. I think you are right. We're going to change this in the near future.

@einpraegsam einpraegsam added the enhancement New feature or request label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants