Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock Electron Update #1902

Closed
lidel opened this issue Sep 6, 2021 · 4 comments · Fixed by #1937
Closed

Unblock Electron Update #1902

lidel opened this issue Sep 6, 2021 · 4 comments · Fixed by #1937
Assignees
@hacdias
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
Maintenance Priorities - JS

Comments

@lidel
Copy link
Member

lidel commented Sep 6, 2021 •
edited

We are 2 versions behind, waiting for https://github.com/electron-userland/spectron/releases to ship something compatible with the latest Electron.
@lidel lidel added exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo need/analysis Needs further analysis before proceeding labels Sep 6, 2021
@hacdias
Copy link
Member

hacdias commented Sep 7, 2021

I will analyse this.

@hacdias hacdias self-assigned this Sep 7, 2021
@hacdias hacdias added this to In Progress in Maintenance Priorities - JS Sep 7, 2021
@hacdias hacdias mentioned this issue Sep 7, 2021
Closed
@hacdias hacdias moved this from In Progress to Parked/Blocked in Maintenance Priorities - JS Sep 7, 2021
@lidel
Copy link
Member Author

lidel commented Oct 4, 2021

Even tho Electron 15 shipped, we can't update.
This is still blocked by the lack of Spectron (tool we use for E2E tests) compatible with Electron 14.

@lidel lidel added status/blocked Unable to be worked further until needs are met and removed need/analysis Needs further analysis before proceeding labels Oct 4, 2021
@lidel lidel changed the title Update to Electron 14 Update to Electron 14 or 15 .... or 16.. whatever works with spectron 😬 Nov 26, 2021
@lidel lidel changed the title Update to Electron 14 or 15 .... or 16.. whatever works with spectron 😬 Update to Electron 14 or 15 .... or 16.. whatever works with spectron Nov 26, 2021
@lidel
Copy link
Member Author

lidel commented Dec 3, 2021 •
edited

so.. spectron is dead: electron-userland/spectron#1045 💀

means we need to invest more work here, and rewrite e2e tests to use playwright:

If anyone has spare bandwidth, PR welcome.

@lidel lidel changed the title Update to Electron 14 or 15 .... or 16.. whatever works with spectron Unblock Electron Update Dec 3, 2021
@lidel lidel pinned this issue Dec 3, 2021
@lidel lidel added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue exp/intermediate Prior experience is likely helpful and removed exp/expert Having worked on the specific codebase is important status/blocked Unable to be worked further until needs are met exp/novice Someone with a little familiarity can pick up labels Dec 3, 2021
@lidel lidel moved this from Parked/Blocked to Weekly Candidates in Maintenance Priorities - JS Dec 3, 2021
@lidel lidel mentioned this issue Dec 3, 2021
Closed
@hacdias
Copy link
Member

hacdias commented Dec 6, 2021

I will look into moving to playwright.

lidel added a commit that referenced this issue Dec 10, 2021
@lidel
chore: minimal bump of electron deps
5b28912 
this is to avoid the need for dealing with
#1902
lidel added a commit that referenced this issue Dec 10, 2021
@lidel
chore: release prep (#1938)
b350681 
* chore(i18n): sync locales

* chore: minimal bump of electron deps

this is to avoid the need for dealing with
#1902

* chore: switch CI to ipfs daemon actions
@hacdias hacdias moved this from Weekly Candidates to In Progress in Maintenance Priorities - JS Dec 17, 2021
@hacdias hacdias self-assigned this Dec 17, 2021
@lidel lidel mentioned this issue Feb 3, 2022
Merged
Maintenance Priorities - JS automation moved this from In Progress to Done Feb 4, 2022
@lidel lidel unpinned this issue Feb 4, 2022
@lidel lidel mentioned this issue May 16, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Maintenance Priorities - JS
Done
Milestone
No milestone
2 participants
@lidel @hacdias