Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly allow CAP NEW to update existing caps #480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emersion
Copy link
Contributor

@emersion emersion commented Dec 2, 2021

Closes: #477

@jwheare
Copy link
Member

jwheare commented Dec 2, 2021

Is there a server that does this at the moment that can be used to test clients?

@emersion
Copy link
Contributor Author

emersion commented Dec 2, 2021

soju does this, but there's no public test instance. FWIW, the clients I've tried are: gamja, weechat, revolution irc, senpai (user reported a bug, now fixed). I haven't received other bug reports from chat.sr.ht users about this.

@jwheare
Copy link
Member

jwheare commented Dec 2, 2021

I imagine it's quite a rare real world situation tbh, and may not manifest in an immediately obvious bug. I'll have a play with a dummy netcat server.

@jwheare
Copy link
Member

jwheare commented Dec 2, 2021

Confirmed that IRCCloud handles this as well.

@emersion
Copy link
Contributor Author

Any objections against landing this?

@jwheare
Copy link
Member

jwheare commented Dec 15, 2021

Would prefer to see some tests with other clients, but I'm fine with it.

@SadieCat
Copy link
Contributor

Any updates on this? InspIRCd currently sends CAP DEL then CAP NEW but I can easily update it to just send CAP NEW if this is merged.

@jwheare
Copy link
Member

jwheare commented Oct 24, 2022

Someone just needs to test other clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear how servers should send cap updates
3 participants